tblyler/reg
1
0
Fork 0
mirror of https://github.com/genuinetools/reg.git synced 2024-05-18 19:28:33 -04:00
Code Issues Projects Releases Wiki Activity

registry: format accept headers (#130)

Browse source 
Multiple calls to request.Header.Add() will overwrite the last value.
This formats the value of the Accept headers correctly so that a
registry can perform content-type negotiation.
This commit is contained in:
Jimmy Zelinskie 2018-09-05 15:03:18 -04:00 committed by Jess Frazelle
parent e641a3626c
commit 5ff93f005b
4 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
registry/delete.go
View file

@ -20,7 +20,7 @@ func (r *Registry) Delete(repository string, digest digest.Digest) (err error) {
return err
}
req.Header.Set("Accept", schema2.MediaTypeManifest)
req.Header.Add("Accept", fmt.Sprintf("%s;q=0.9", schema2.MediaTypeManifest))
resp, err := r.Client.Do(req)
if err != nil {
return err

2
registry/digest.go
View file

@ -24,7 +24,7 @@ func (r *Registry) Digest(image Image) (digest.Digest, error) {
return "", err
}
req.Header.Set("Accept", schema2.MediaTypeManifest)
req.Header.Add("Accept", fmt.Sprintf("%s;q=0.9", schema2.MediaTypeManifest))
resp, err := r.Client.Do(req)
if err != nil {
return "", err

4
registry/manifest.go
View file

@ -3,6 +3,7 @@ package registry
import (
"bytes"
"encoding/json"
"fmt"
"io/ioutil"
"net/http"
@ -22,8 +23,7 @@ func (r *Registry) Manifest(repository, ref string) (distribution.Manifest, erro
return nil, err
}
req.Header.Add("Accept", schema2.MediaTypeManifest)
req.Header.Add("Accept", manifestlist.MediaTypeManifestList)
req.Header.Add("Accept", fmt.Sprintf("%s,%s;q=0.9", schema2.MediaTypeManifest, manifestlist.MediaTypeManifestList))
resp, err := r.Client.Do(req)
if err != nil {

3
registry/registry.go
View file

@ -130,8 +130,7 @@ func (r *Registry) getJSON(url string, response interface{}, addV2Header bool) (
return nil, err
}
if addV2Header {
req.Header.Add("Accept", schema2.MediaTypeManifest)
req.Header.Add("Accept", manifestlist.MediaTypeManifestList)
req.Header.Add("Accept", fmt.Sprintf("%s,%s;q=0.9", schema2.MediaTypeManifest, manifestlist.MediaTypeManifestList))
}
resp, err := r.Client.Do(req)
if err != nil {